summary refs log tree commit diff stats
path: root/hw/gpio/omap_gpio.c
diff options
context:
space:
mode:
authorStefano Stabellini <sstabellini@kernel.org>2017-05-03 14:00:35 -0700
committerStefano Stabellini <sstabellini@kernel.org>2017-05-16 11:49:09 -0700
commit1ff7c5986a515d2d936eba026ff19947bbc7cb92 (patch)
tree66bc3e4afe6223b30a7dfd169203a5ad01758e77 /hw/gpio/omap_gpio.c
parentcdece0467c00007cf8e3f4b3c3f0b13bf2c4fea9 (diff)
downloadfocaccia-qemu-1ff7c5986a515d2d936eba026ff19947bbc7cb92.tar.gz
focaccia-qemu-1ff7c5986a515d2d936eba026ff19947bbc7cb92.zip
xen/mapcache: store dma information in revmapcache entries for debugging
The Xen mapcache is able to create long term mappings, they are called
"locked" mappings. The third parameter of the xen_map_cache call
specifies if a mapping is a "locked" mapping.

>From the QEMU point of view there are two kinds of long term mappings:

[a] device memory mappings, such as option roms and video memory
[b] dma mappings, created by dma_memory_map & friends

After certain operations, ballooning a VM in particular, Xen asks QEMU
kindly to destroy all mappings. However, certainly [a] mappings are
present and cannot be removed. That's not a problem as they are not
affected by balloonning. The *real* problem is that if there are any
mappings of type [b], any outstanding dma operations could fail. This is
a known shortcoming. In other words, when Xen asks QEMU to destroy all
mappings, it is an error if any [b] mappings exist.

However today we have no way of distinguishing [a] from [b]. Because of
that, we cannot even print a decent warning.

This patch introduces a new "dma" bool field to MapCacheRev entires, to
remember if a given mapping is for dma or is a long term device memory
mapping. When xen_invalidate_map_cache is called, we print a warning if
any [b] mappings exist. We ignore [a] mappings.

Mappings created by qemu_map_ram_ptr are assumed to be [a], while
mappings created by address_space_map->qemu_ram_ptr_length are assumed
to be [b].

The goal of the patch is to make debugging and system understanding
easier.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Diffstat (limited to 'hw/gpio/omap_gpio.c')
0 files changed, 0 insertions, 0 deletions