summary refs log tree commit diff stats
path: root/hw/i2c/aspeed_i2c.c
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2023-06-05 21:52:54 +0200
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2023-06-13 11:28:58 +0200
commitbb6af0fa51cac875e5986aada0de339dcc94eca5 (patch)
treed9cc9c4bb88ec09a7b03fe173e8e9ff91d1b9d0f /hw/i2c/aspeed_i2c.c
parent0baf54d0056979d6344b872a5b20acb6a5fd3cf8 (diff)
downloadfocaccia-qemu-bb6af0fa51cac875e5986aada0de339dcc94eca5.tar.gz
focaccia-qemu-bb6af0fa51cac875e5986aada0de339dcc94eca5.zip
util/cacheflush: Avoid possible redundant dcache flush on Darwin
<libkern/OSCacheControl.h> describes sys_icache_invalidate() as
"equivalent to sys_cache_control(kCacheFunctionPrepareForExecution)",
having kCacheFunctionPrepareForExecution defined as:

  /* Prepare memory for execution.  This should be called
   * after writing machine instructions to memory, before
   * executing them.  It syncs the dcache and icache. [...]
   */

Since the dcache is also sync'd, we can avoid the sys_dcache_flush()
call when both rx/rw pointers are equal.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20230605195911.96033-1-philmd@linaro.org>
Diffstat (limited to 'hw/i2c/aspeed_i2c.c')
0 files changed, 0 insertions, 0 deletions