summary refs log tree commit diff stats
path: root/hw/i2c/omap_i2c.c
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2021-07-09 10:39:50 -0500
committerEric Blake <eblake@redhat.com>2021-07-21 14:14:41 -0500
commit74a4320f30632fa539507861b3835698282e462e (patch)
tree726ed608ae7eb0881adc5ab0cae3d51e38ac53ec /hw/i2c/omap_i2c.c
parent94075c28eea0755173939dfaf1eae688b224a74e (diff)
downloadfocaccia-qemu-74a4320f30632fa539507861b3835698282e462e.tar.gz
focaccia-qemu-74a4320f30632fa539507861b3835698282e462e.zip
qemu-img: Fail fast on convert --bitmaps with inconsistent bitmap
Waiting until the end of the convert operation (a potentially
time-consuming task) to finally detect that we can't copy a bitmap is
bad, comparing to failing fast up front.  Furthermore, this prevents
us from leaving a file behind with a bitmap that is not marked as
inconsistent even though it does not have sane contents.

This fixes the problems exposed in the previous patch to the iotest:
it adds a fast failure up front, and even if we don't fail early, it
ensures that any bitmap we add but do not properly populate is removed
again rather than left behind incomplete.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20210709153951.2801666-3-eblake@redhat.com>
[eblake: add a hint to the warning message, simplify name computation]
Reviewed-by: Nir Soffer <nsoffer@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Diffstat (limited to 'hw/i2c/omap_i2c.c')
0 files changed, 0 insertions, 0 deletions