diff options
| author | Jan Kiszka <jan.kiszka@siemens.com> | 2011-05-09 17:48:19 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2011-05-18 14:38:46 +0200 |
| commit | 4d29b50a41810684ad34e44352a630eb1dd94b58 (patch) | |
| tree | 7e6f6ce5d0549ba839036d13fe34ebfd2acc62dd /hw/ide/ahci.c | |
| parent | 3bfe4dbf92d98d8c119b74f6c90b42fd8f289b58 (diff) | |
| download | focaccia-qemu-4d29b50a41810684ad34e44352a630eb1dd94b58.tar.gz focaccia-qemu-4d29b50a41810684ad34e44352a630eb1dd94b58.zip | |
ahci: Fix crashes on duplicate BH registration
If ahci_dma_set_inactive is called a while there is still a pending BH from a previous run, we will crash on the second run of ahci_check_cmd_bh as it overwrites AHCIDevice::check_bh. Avoid this broken and redundant duplicate registration. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/ide/ahci.c')
| -rw-r--r-- | hw/ide/ahci.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index c6e0c7767e..744d19d6db 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1066,9 +1066,11 @@ static int ahci_dma_set_inactive(IDEDMA *dma) ad->dma_cb = NULL; - /* maybe we still have something to process, check later */ - ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad); - qemu_bh_schedule(ad->check_bh); + if (!ad->check_bh) { + /* maybe we still have something to process, check later */ + ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad); + qemu_bh_schedule(ad->check_bh); + } return 0; } |