diff options
| author | Ashijeet Acharya <ashijeetacharya@gmail.com> | 2016-09-27 22:23:32 +0530 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2016-09-29 15:50:29 -0400 |
| commit | ca44141d5fb801dd5903102acefd0f2d8e8bb6a1 (patch) | |
| tree | fad957e61614cb179d6fc731af800ba72a07b79b /hw/ide/core.c | |
| parent | c9f7acd57552b919a7b9b1c381383960307c0ada (diff) | |
| download | focaccia-qemu-ca44141d5fb801dd5903102acefd0f2d8e8bb6a1.tar.gz focaccia-qemu-ca44141d5fb801dd5903102acefd0f2d8e8bb6a1.zip | |
ide: Fix memory leak in ide_register_restart_cb()
Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which might lead to a crash. Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com> Reviewed-by: John Snow <jsnow@redhat.com> Message-id: 1474995212-10580-1-git-send-email-ashijeetacharya@gmail.com [Minor whitespace fix --js] Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'hw/ide/core.c')
| -rw-r--r-- | hw/ide/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/ide/core.c b/hw/ide/core.c index 1bee18d86e..7291677109 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2582,7 +2582,7 @@ static void ide_restart_cb(void *opaque, int running, RunState state) void ide_register_restart_cb(IDEBus *bus) { if (bus->dma->ops->restart_dma) { - qemu_add_vm_change_state_handler(ide_restart_cb, bus); + bus->vmstate = qemu_add_vm_change_state_handler(ide_restart_cb, bus); } } |