diff options
| author | Markus Armbruster <armbru@redhat.com> | 2014-10-24 12:19:11 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2014-10-24 12:19:11 +0100 |
| commit | 7797a73947d5c0e63dd5552b348cf66c384b4555 (patch) | |
| tree | 9e48798870378c8af03dfe2138682055768726a2 /hw/ide/microdrive.c | |
| parent | 1430500bb8ba0bf15bad235439d62276c1b6b22f (diff) | |
| download | focaccia-qemu-7797a73947d5c0e63dd5552b348cf66c384b4555.tar.gz focaccia-qemu-7797a73947d5c0e63dd5552b348cf66c384b4555.zip | |
hmp: Remove "info pcmcia"
This command lists PCMCIA sockets and cards. Only a few ARM boards have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa, verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev "microdrive"), and it is only inserted during machine init, if ever. So this command doesn't really tell anybody anything new so far. Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged by Coverity. Has never been used, because there has never been code to eject a PCMCIA card. Not worth fixing & converting to QMP. Remove it. Signed-off-by: Markus Armbruster <armbru@redhat.com> Acked-by: Luiz Capitulino <lcapitulino@redhat.com> Acked-by: Andreas Färber <afaerber@suse.de> Message-id: 1411144812-22958-1-git-send-email-armbru@redhat.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/ide/microdrive.c')
| -rw-r--r-- | hw/ide/microdrive.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/ide/microdrive.c b/hw/ide/microdrive.c index ed85185a74..6639dd4886 100644 --- a/hw/ide/microdrive.c +++ b/hw/ide/microdrive.c @@ -543,7 +543,6 @@ static int dscm1xxxx_attach(PCMCIACardState *card) device_reset(DEVICE(md)); md_interrupt_update(md); - card->slot->card_string = "DSCM-1xxxx Hitachi Microdrive"; return 0; } |