diff options
| author | Ryan Harper <ryanh@us.ibm.com> | 2010-12-08 10:05:00 -0600 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2010-12-17 16:10:59 +0100 |
| commit | 0fc0f1fa7f86e9f1d480c6508191ca90ac10b32c (patch) | |
| tree | 221b0364884fc3d58d1391e5dfaf90ce37af9688 /hw/ide/pci.c | |
| parent | 9d861fa595c93f22d1d55b723a691531c36c9672 (diff) | |
| download | focaccia-qemu-0fc0f1fa7f86e9f1d480c6508191ca90ac10b32c.tar.gz focaccia-qemu-0fc0f1fa7f86e9f1d480c6508191ca90ac10b32c.zip | |
blockdev: check dinfo ptr before using
If a user decides to punish a guest by revoking its block device via drive_del, and subsequently also attempts to remove the pci device backing it, and the device is using blockdev_auto_del() then we get a segfault when we attempt to access dinfo->auto_del.[1] The fix is to check if drive_get_by_blockdev() actually returns a valid dinfo pointer or not. 1. (qemu) pci_add auto storage file=images/test01.raw,if=virtio,id=block1,snapshot=on (qemu) drive_del block1 (qemu) pci_del 5 *segfault* Signed-off-by: Ryan Harper <ryanh@us.ibm.com> Tested-by: Luiz Capitulino <lcapitulino@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/ide/pci.c')
0 files changed, 0 insertions, 0 deletions