summary refs log tree commit diff stats
path: root/hw/ide/pci.c
diff options
context:
space:
mode:
authorRadim Krčmář <rkrcmar@redhat.com>2015-02-20 17:06:15 +0100
committerMichael Tokarev <mjt@tls.msk.ru>2015-03-10 08:15:34 +0300
commit8c1ac475e30091ba77a075d5e2136ece4f7c9cd0 (patch)
treeffe08b8da8cb4b3b6c83b18d8209643ef8c1fb1f /hw/ide/pci.c
parent02942db7982541716131ca486ca0d59eae107553 (diff)
downloadfocaccia-qemu-8c1ac475e30091ba77a075d5e2136ece4f7c9cd0.tar.gz
focaccia-qemu-8c1ac475e30091ba77a075d5e2136ece4f7c9cd0.zip
fix GCC 5.0.0 logical-not-parentheses warnings
man gcc:
  Warn about logical not used on the left hand side operand of a
  comparison.  This option does not warn if the RHS operand is of a
  boolean type.

By preferring bool over int where sensible, but without modifying any
depending code, make GCC happy in cases like this,
  qemu-img.c: In function ‘compare_sectors’:
  qemu-img.c:992:39: error: logical not is only applied to the left hand
  side of comparison [-Werror=logical-not-parentheses]
           if (!!memcmp(buf1, buf2, 512) != res) {

hw/ide/core.c:1836 doesn't throw an error,
  assert(!!s->error == !!(s->status & ERR_STAT));
even thought the second operand is int (and first hunk of this patch has
a very similar case), maybe GCC developers still have a little faith in
C programmers.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw/ide/pci.c')
0 files changed, 0 insertions, 0 deletions