summary refs log tree commit diff stats
path: root/hw/intc/apic.c
diff options
context:
space:
mode:
authorJuan Quintela <quintela@redhat.com>2023-10-20 11:07:25 +0200
committerJuan Quintela <quintela@redhat.com>2023-11-01 16:13:58 +0100
commit485fb95546e1cc94e77b93ff785bdbfa2c1d3ff1 (patch)
tree1ebc4df397ac57fcabe30bce09fe71fc720aeb40 /hw/intc/apic.c
parentb23db4cd8218345a7ec75a8ff810896ce3a391b1 (diff)
downloadfocaccia-qemu-485fb95546e1cc94e77b93ff785bdbfa2c1d3ff1.tar.gz
focaccia-qemu-485fb95546e1cc94e77b93ff785bdbfa2c1d3ff1.zip
migration: Hack to maintain backwards compatibility for ppc
Current code does:
- register pre_2_10_vmstate_dummy_icp with "icp/server" and instance
  dependinfg on cpu number
- for newer machines, it register vmstate_icp with "icp/server" name
  and instance 0
- now it unregisters "icp/server" for the 1st instance.

This is wrong at many levels:
- we shouldn't have two VMSTATEDescriptions with the same name
- In case this is the only solution that we can came with, it needs to
  be:
  * register pre_2_10_vmstate_dummy_icp
  * unregister pre_2_10_vmstate_dummy_icp
  * register real vmstate_icp

Created vmstate_replace_hack_for_ppc() with warnings left and right
that it is a hack.

CC: Cedric Le Goater <clg@kaod.org>
CC: Daniel Henrique Barboza <danielhb413@gmail.com>
CC: David Gibson <david@gibson.dropbear.id.au>
CC: Greg Kurz <groug@kaod.org>

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20231020090731.28701-8-quintela@redhat.com>
Diffstat (limited to 'hw/intc/apic.c')
0 files changed, 0 insertions, 0 deletions