summary refs log tree commit diff stats
path: root/hw/intc/apic_common.c
diff options
context:
space:
mode:
authorAlex Williamson <alex.williamson@redhat.com>2015-04-28 11:14:02 -0600
committerAlex Williamson <alex.williamson@redhat.com>2015-04-28 11:14:02 -0600
commit07ceaf98800519ef9c5dc893af00f1fe1f9144e4 (patch)
treecd082239429f6870ebd9f78df3df0e1677fe97b4 /hw/intc/apic_common.c
parent84cbd63f87c1d246f51ec8eee5367a5588f367fd (diff)
downloadfocaccia-qemu-07ceaf98800519ef9c5dc893af00f1fe1f9144e4.tar.gz
focaccia-qemu-07ceaf98800519ef9c5dc893af00f1fe1f9144e4.zip
vfio-pci: Further fix BAR size overflow
In an analysis by Laszlo, the resulting type of our calculation for
the end of the MSI-X table, and thus the start of memory after the
table, is uint32_t.  We're therefore not correctly preventing the
corner case overflow that we intended to fix here where a BAR >=4G
could place the MSI-X table to end exactly at the 4G boundary.  The
MSI-X table offset is defined by the hardware spec to 32bits, so we
simply use a cast rather than changing data structure types.  This
scenario is purely theoretically, typically the MSI-X table is located
at the front of the BAR.

Reported-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'hw/intc/apic_common.c')
0 files changed, 0 insertions, 0 deletions