summary refs log tree commit diff stats
path: root/hw/intc/omap_intc.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2016-09-21 16:52:23 +0100
committerMichael S. Tsirkin <mst@redhat.com>2016-09-23 19:03:56 +0300
commitb1c7c07f2db2096451791882e9d1cdc301b66cdb (patch)
treebbfc6e4fd057f5be8959457d843ce7db9336d775 /hw/intc/omap_intc.c
parentd65abf85e7e5fce31905eaea322ef2ea26e5f2db (diff)
downloadfocaccia-qemu-b1c7c07f2db2096451791882e9d1cdc301b66cdb.tar.gz
focaccia-qemu-b1c7c07f2db2096451791882e9d1cdc301b66cdb.zip
virtio: use unsigned int for virtqueue_get_avail_bytes() index
The virtio code uses int, unsigned int, and uint16_t for virtqueue
indices.  The uint16_t is used for the low-level descriptor layout in
virtio_ring.h while code that isn't concerned with descriptor layout can
use unsigned int.

Use of int is problematic because it can result in signed/unsigned
comparison and incompatible int*/unsigned int* pointer types.

Make the virtqueue_get_avail_bytes() 'i' variable unsigned int.  This
eliminates the need to introduce casts and modify code further in the
patches that follow.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Diffstat (limited to 'hw/intc/omap_intc.c')
0 files changed, 0 insertions, 0 deletions