summary refs log tree commit diff stats
path: root/hw/intc
diff options
context:
space:
mode:
authorGreg Kurz <groug@kaod.org>2020-08-10 18:53:58 +0200
committerDavid Gibson <david@gibson.dropbear.id.au>2020-08-13 21:00:52 +1000
commit4a6891b838e4914d25ab97a2a03f946e3c085a8f (patch)
tree4d11c70547a8faa4d3b04b2ef127b26afcdad116 /hw/intc
parenta4907119348d928e8b72e2d3b7566e50f272fa09 (diff)
downloadfocaccia-qemu-4a6891b838e4914d25ab97a2a03f946e3c085a8f.tar.gz
focaccia-qemu-4a6891b838e4914d25ab97a2a03f946e3c085a8f.zip
spapr: Simplify error handling in spapr_phb_realize()
The spapr_phb_realize() function has a local_err variable which
is used to:

1) check failures of spapr_irq_findone() and spapr_irq_claim()

2) prepend extra information to the error message

Recent work from Markus Armbruster highlighted we get better
code when testing the return value of a function, rather than
setting up all the local_err boiler plate. For similar reasons,
it is now preferred to use ERRP_GUARD() and error_prepend()
rather than error_propagate_prepend().

Since spapr_irq_findone() and spapr_irq_claim() return negative
values in case of failure, do both changes.

This is just cleanup, no functional impact.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <159707843851.1489912.6108405733810934642.stgit@bahia.lan>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/intc')
0 files changed, 0 insertions, 0 deletions