summary refs log tree commit diff stats
path: root/hw/kvm/pci-assign.c
diff options
context:
space:
mode:
authorAmit Shah <amit.shah@redhat.com>2012-12-12 18:26:09 +0530
committerAmit Shah <amit.shah@redhat.com>2012-12-18 13:04:42 +0530
commit4e28976e563ad54f6adc5ae00b1fb8224f1a82ca (patch)
tree0ad707ebc88889f892dd51d9767fc021c4ae2185 /hw/kvm/pci-assign.c
parenta75bf146503a94fb900e0dfa0529bd5d1be9fec5 (diff)
downloadfocaccia-qemu-4e28976e563ad54f6adc5ae00b1fb8224f1a82ca.tar.gz
focaccia-qemu-4e28976e563ad54f6adc5ae00b1fb8224f1a82ca.zip
virtio-serial-bus: send_control_msg() should not deal with cpkts
Stuff the cpkt before calling send_control_msg().  This function should
not be concerned about contents of the buffer it receives.

A few code refactorings recently have made making this change easier
than earlier.

Coverity and clang have flagged this code several times in the past
(cpkt->id not set before send_control_event() passed it on to
send_control_msg()).  This will finally eliminate the false-positive.

CC: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Diffstat (limited to 'hw/kvm/pci-assign.c')
0 files changed, 0 insertions, 0 deletions