diff options
| author | Julia Suvorova <jusual@redhat.com> | 2022-10-23 21:58:12 +0200 |
|---|---|---|
| committer | David Hildenbrand <david@redhat.com> | 2022-10-24 12:38:38 +0200 |
| commit | d0180f0acb142ca78e30857b8d8511ee9f3bd764 (patch) | |
| tree | b08bf806e541ae2e9e5ae4a9a624de656e85c756 /hw/mem/nvdimm.c | |
| parent | 0529245488865038344d64fff7ee05864d3d17f6 (diff) | |
| download | focaccia-qemu-d0180f0acb142ca78e30857b8d8511ee9f3bd764.tar.gz focaccia-qemu-d0180f0acb142ca78e30857b8d8511ee9f3bd764.zip | |
hw/mem/nvdimm: fix error message for 'unarmed' flag
In the ACPI specification [1], the 'unarmed' bit is set when a device
cannot accept a persistent write. This means that when a memdev is
read-only, the 'unarmed' flag must be turned on. The logic is correct,
just changing the error message.
[1] ACPI NFIT NVDIMM Region Mapping Structure "NVDIMM State Flags" Bit 3
Fixes: dbd730e859 ("nvdimm: check -object memory-backend-file, readonly=on option")
Signed-off-by: Julia Suvorova <jusual@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: David Hildenbrand <david@redhat.com>
Message-Id: <20221023195812.15523-1-jusual@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Diffstat (limited to 'hw/mem/nvdimm.c')
| -rw-r--r-- | hw/mem/nvdimm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 7c7d777781..31080c22c9 100644 --- a/hw/mem/nvdimm.c +++ b/hw/mem/nvdimm.c @@ -149,7 +149,7 @@ static void nvdimm_prepare_memory_region(NVDIMMDevice *nvdimm, Error **errp) if (!nvdimm->unarmed && memory_region_is_rom(mr)) { HostMemoryBackend *hostmem = dimm->hostmem; - error_setg(errp, "'unarmed' property must be off since memdev %s " + error_setg(errp, "'unarmed' property must be 'on' since memdev %s " "is read-only", object_get_canonical_path_component(OBJECT(hostmem))); return; |