summary refs log tree commit diff stats
path: root/hw/mips/cputimer.c
diff options
context:
space:
mode:
authorSanjay Lal <sanjayl@kymasys.com>2014-06-17 23:10:27 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2014-06-18 16:57:52 +0200
commit353a243e22fae2b993ab7f2d123c2b81013b3c5d (patch)
treeae93336456dfa862c4b872b2a67b5bdee41dab7a /hw/mips/cputimer.c
parent4b69c7e265a2c2fd1120c431c5d8d0809d4ec10a (diff)
downloadfocaccia-qemu-353a243e22fae2b993ab7f2d123c2b81013b3c5d.tar.gz
focaccia-qemu-353a243e22fae2b993ab7f2d123c2b81013b3c5d.zip
hw/mips/cputimer: Don't start periodic timer in KVM mode
Compare/Count timer interrupts are handled in-kernel for KVM. Therefore
don't bother creating the timer at init time if KVM is enabled. This
will conveniently avoid attempts to set the timeout when
cpu_mips_store_count() is called at reset with KVM enabled, treating the
timer as stopped so that CP0_Count is modified directly.

Signed-off-by: Sanjay Lal <sanjayl@kymasys.com>
[james.hogan@imgtec.com: Update after "target-mips: Reset CPU timer
consistently" which moves timer start to reset time]
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/mips/cputimer.c')
-rw-r--r--hw/mips/cputimer.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/hw/mips/cputimer.c b/hw/mips/cputimer.c
index 6900a745c6..577c9aeab8 100644
--- a/hw/mips/cputimer.c
+++ b/hw/mips/cputimer.c
@@ -23,6 +23,7 @@
 #include "hw/hw.h"
 #include "hw/mips/cpudevs.h"
 #include "qemu/timer.h"
+#include "sysemu/kvm.h"
 
 #define TIMER_FREQ	100 * 1000 * 1000
 
@@ -146,5 +147,11 @@ static void mips_timer_cb (void *opaque)
 
 void cpu_mips_clock_init (CPUMIPSState *env)
 {
-    env->timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, &mips_timer_cb, env);
+    /*
+     * If we're in KVM mode, don't create the periodic timer, that is handled in
+     * kernel.
+     */
+    if (!kvm_enabled()) {
+        env->timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, &mips_timer_cb, env);
+    }
 }