diff options
| author | Daniel P. Berrange <berrange@redhat.com> | 2015-08-26 12:17:18 +0100 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2015-09-11 10:21:38 +0300 |
| commit | ef1e1e0782e99c9dcf2b35e5310cdd8ca9211374 (patch) | |
| tree | 0b0f9a746055b66019016ed2d8e4ff9df7d79a8c /hw/mips/mips_r4k.c | |
| parent | 4595a48a10e576638795950b61957f83d2ed09b4 (diff) | |
| download | focaccia-qemu-ef1e1e0782e99c9dcf2b35e5310cdd8ca9211374.tar.gz focaccia-qemu-ef1e1e0782e99c9dcf2b35e5310cdd8ca9211374.zip | |
maint: avoid useless "if (foo) free(foo)" pattern
The free() and g_free() functions both happily accept NULL on any platform QEMU builds on. As such putting a conditional 'if (foo)' check before calls to 'free(foo)' merely serves to bloat the lines of code. Signed-off-by: Daniel P. Berrange <berrange@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw/mips/mips_r4k.c')
| -rw-r--r-- | hw/mips/mips_r4k.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c index f4dcacd862..86b2c0bcb7 100644 --- a/hw/mips/mips_r4k.c +++ b/hw/mips/mips_r4k.c @@ -252,9 +252,7 @@ void mips_r4k_init(MachineState *machine) fprintf(stderr, "qemu: Warning, could not load MIPS bios '%s'\n", bios_name); } - if (filename) { - g_free(filename); - } + g_free(filename); if (kernel_filename) { loaderparams.ram_size = ram_size; |