summary refs log tree commit diff stats
path: root/hw/misc/aspeed_sdmc.c
diff options
context:
space:
mode:
authorDaniel Henrique Barboza <danielhb413@gmail.com>2020-04-13 17:36:28 -0300
committerDavid Gibson <david@gibson.dropbear.id.au>2020-05-07 11:10:50 +1000
commit70fc9cb0920fce3c2c0a090e69bf06d39f4b2362 (patch)
tree1036957b57378f567fe5592f39d2cc4f174b6658 /hw/misc/aspeed_sdmc.c
parentd04ea940c597201a6610c5d1712809ed35dd77ec (diff)
downloadfocaccia-qemu-70fc9cb0920fce3c2c0a090e69bf06d39f4b2362.tar.gz
focaccia-qemu-70fc9cb0920fce3c2c0a090e69bf06d39f4b2362.zip
spapr_nvdimm.c: make 'label-size' mandatory
The pseries machine does not support NVDIMM modules without label.
Attempting to do so, even if the overall block size is aligned with
256MB, will seg fault the guest kernel during NVDIMM probe. This
can be avoided by forcing 'label-size' to always be present for
sPAPR NVDIMMs.

The verification was put before the alignment check because the
presence of label-size affects the alignment calculation, so
it's not optimal to warn the user about an alignment error,
then about the lack of label-size, then about a new alignment
error when the user sets a label-size.

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20200413203628.31636-1-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/misc/aspeed_sdmc.c')
0 files changed, 0 insertions, 0 deletions