diff options
| author | Zheyu Ma <zheyuma97@gmail.com> | 2024-06-18 18:37:01 +0200 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2024-06-21 16:20:45 +0100 |
| commit | d338b5a80922433a2c4a63986b41f82ae4137dfc (patch) | |
| tree | 61ef4846839eed746bb2d6072149385a68069f54 /hw/misc/exynos4210_rng.c | |
| parent | dda533087ad5559674ff486e7031c88dc01e0abd (diff) | |
| download | focaccia-qemu-d338b5a80922433a2c4a63986b41f82ae4137dfc.tar.gz focaccia-qemu-d338b5a80922433a2c4a63986b41f82ae4137dfc.zip | |
hw/misc: Set valid access size for Exynos4210 RNG
The Exynos4210 RNG module requires 32-bit (4-byte) accesses to its registers. According to the User Manual Section 25.3[1], the registers for RNG operations are 32-bit. This change ensures that the memory region operations for the RNG module enforce the correct access sizes, preventing invalid memory accesses. [1] http://www.mediafire.com/view/8ly2fqls3c9c31c/Exynos_4412_SCP_Users_Manual_Ver.0.10.00_Preliminary0.pdf Reproducer: cat << EOF | qemu-system-aarch64 -display none \ -machine accel=qtest, -m 512M -machine smdkc210 -qtest stdio readb 0x10830454 EOF Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> Message-id: 20240618163701.3204975-1-zheyuma97@gmail.com Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/misc/exynos4210_rng.c')
| -rw-r--r-- | hw/misc/exynos4210_rng.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/misc/exynos4210_rng.c b/hw/misc/exynos4210_rng.c index 0756bd3205..674d8eece5 100644 --- a/hw/misc/exynos4210_rng.c +++ b/hw/misc/exynos4210_rng.c @@ -217,6 +217,8 @@ static const MemoryRegionOps exynos4210_rng_ops = { .read = exynos4210_rng_read, .write = exynos4210_rng_write, .endianness = DEVICE_NATIVE_ENDIAN, + .valid.min_access_size = 4, + .valid.max_access_size = 4, }; static void exynos4210_rng_reset(DeviceState *dev) |