diff options
| author | Max Reitz <mreitz@redhat.com> | 2015-02-27 12:11:53 -0500 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2015-03-02 10:57:07 +0100 |
| commit | f6758f7d6b8b483eb1d061937ed06da830c1ecb8 (patch) | |
| tree | f89515e3d19b7fa3fcd010a0621f1cae733bc14c /hw/misc/macio/cuda.c | |
| parent | a9ad5e1efcbbdf4b34bd7679613605efdb41bd04 (diff) | |
| download | focaccia-qemu-f6758f7d6b8b483eb1d061937ed06da830c1ecb8.tar.gz focaccia-qemu-f6758f7d6b8b483eb1d061937ed06da830c1ecb8.zip | |
virtio-scsi: Allocate op blocker reason before blocking
s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places
where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is
allocated and when it is freed. That does not make a whole lot of sense
(and is actually wrong because this leads to s->blocker potentially
being NULL when blk_op_block_all() is called in virtio-scsi.c), so move
the allocation and destruction of s->blocker to the device realization
and unrealization in virtio-scsi.c, respectively.
Case in point:
$ echo -e 'eject drv\nquit' | \
x86_64-softmmu/qemu-system-x86_64 \
-monitor stdio -machine accel=qtest -display none \
-object iothread,id=thr -device virtio-scsi-pci,iothread=thr \
-drive if=none,file=test.qcow2,format=qcow2,id=drv \
-device scsi-cd,drive=drv
Without this patch:
(qemu) eject drv
[1] 10102 done
10103 segmentation fault (core dumped)
With this patch:
(qemu) eject drv
Device 'drv' is busy: block device is in use by data plane
(qemu) quit
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <1425057113-26940-1-git-send-email-mreitz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/misc/macio/cuda.c')
0 files changed, 0 insertions, 0 deletions