diff options
| author | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | 2021-09-06 22:06:46 +0300 |
|---|---|---|
| committer | Eric Blake <eblake@redhat.com> | 2021-09-29 13:46:33 -0500 |
| commit | f7ca4aadca865898ef9c52d75f142a9db622c712 (patch) | |
| tree | 1f1be2728e558d20fec6e9144645fb28510590ec /hw/misc/macio/cuda.c | |
| parent | da24597dd37bc31b4d2328e5542fa3b5676a3fe0 (diff) | |
| download | focaccia-qemu-f7ca4aadca865898ef9c52d75f142a9db622c712.tar.gz focaccia-qemu-f7ca4aadca865898ef9c52d75f142a9db622c712.zip | |
nbd/client-connection: nbd_co_establish_connection(): fix non set errp
When we don't have a connection and blocking is false, we return NULL but don't set errp. That's wrong. We have two paths for calling nbd_co_establish_connection(): 1. nbd_open() -> nbd_do_establish_connection() -> ... but that will never set blocking=false 2. nbd_reconnect_attempt() -> nbd_co_do_establish_connection() -> ... but that uses errp=NULL So, we are safe with our wrong errp policy in nbd_co_establish_connection(). Still let's fix it. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Message-Id: <20210906190654.183421-2-vsementsov@virtuozzo.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'hw/misc/macio/cuda.c')
0 files changed, 0 insertions, 0 deletions