summary refs log tree commit diff stats
path: root/hw/misc/macio/mac_dbdma.c
diff options
context:
space:
mode:
authorGreg Kurz <gkurz@linux.vnet.ibm.com>2016-02-25 19:02:18 +0100
committerDavid Gibson <david@gibson.dropbear.id.au>2016-02-28 16:19:02 +1100
commitce266b75febdeee5b91ab630a7158ddff3e002fb (patch)
treefcb0bda0d987f0fa22714f474e984a7de1525ce2 /hw/misc/macio/mac_dbdma.c
parentd4a63ac8b19eb208465f27fde63f3cff7018fdfd (diff)
downloadfocaccia-qemu-ce266b75febdeee5b91ab630a7158ddff3e002fb.tar.gz
focaccia-qemu-ce266b75febdeee5b91ab630a7158ddff3e002fb.zip
spapr_pci: fix irq leak in RTAS ibm,change-msi
This RTAS call is used to request new interrupts or to free all interrupts.

If the driver has already allocated interrupts and asks again for a non-null
number of irqs, then the rtas_ibm_change_msi() function will silently leak
the previous interrupts.

It happens because xics_free() is only called when the driver releases all
interrupts (!req_num case). Note that the previously allocated spapr_pci_msi
is not leaked because the GHashTable is created with destroy functions and
g_hash_table_insert() hence frees the old value.

This patch makes sure any previously allocated MSIs are released when a
new allocation succeeds.

Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/misc/macio/mac_dbdma.c')
0 files changed, 0 insertions, 0 deletions