summary refs log tree commit diff stats
path: root/hw/misc
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2018-06-29 15:11:19 +0100
committerPeter Maydell <peter.maydell@linaro.org>2018-06-29 15:11:19 +0100
commit13606b99515e8c5f81eab7fd88a70fb2ad506cd8 (patch)
tree3be73fe2c36e6dafca09e6ede8ba0d6daa2a0985 /hw/misc
parentb7d793ad3db06401bc817c0ca355a2d160c802d4 (diff)
downloadfocaccia-qemu-13606b99515e8c5f81eab7fd88a70fb2ad506cd8.tar.gz
focaccia-qemu-13606b99515e8c5f81eab7fd88a70fb2ad506cd8.zip
sd: Don't trace SDRequest crc field
We don't actually implement SD command CRC checking, because
for almost all of our SD controllers the CRC generation is
done in hardware, and so modelling CRC generation and checking
would be a bit pointless. (The exception is that milkymist-memcard
makes the guest software compute the CRC.)

As a result almost all of our SD controller models don't bother
to set the SDRequest crc field, and the SD card model doesn't
check it. So the tracing of it in sdbus_do_command() provokes
Coverity warnings about use of uninitialized data.

Drop the CRC field from the trace; we can always add it back
if and when we do anything useful with the CRC.

Fixes Coverity issues 1386072, 1386074, 1386076, 1390571.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180626180324.5537-1-peter.maydell@linaro.org
Diffstat (limited to 'hw/misc')
0 files changed, 0 insertions, 0 deletions