summary refs log tree commit diff stats
path: root/hw/moxie/moxiesim.c
diff options
context:
space:
mode:
authorBALATON Zoltan <balaton@eik.bme.hu>2020-07-05 19:22:11 +0200
committerAlistair Francis <alistair.francis@wdc.com>2020-09-25 16:52:08 -0700
commit617160c9e1f8022563c33aa7fd204535d4d49f8c (patch)
tree9bdc09357ec3690c71f21058d88bada7b977bb33 /hw/moxie/moxiesim.c
parent8d16e72f2d4df2c9e631393adf1669a1da7efe8a (diff)
downloadfocaccia-qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.tar.gz
focaccia-qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.zip
load_elf: Remove unused address variables from callers
Several callers of load_elf() pass pointers for lowaddr and highaddr
parameters which are then not used for anything. This may stem from a
misunderstanding that load_elf need a value here but in fact it can
take NULL to ignore these values. Remove such unused variables and
pass NULL instead from callers that don't need these.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Message-Id: <20200705174020.BDD0174633F@zero.eik.bme.hu>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'hw/moxie/moxiesim.c')
-rw-r--r--hw/moxie/moxiesim.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/moxie/moxiesim.c b/hw/moxie/moxiesim.c
index 51a98287b5..a765e9f6be 100644
--- a/hw/moxie/moxiesim.c
+++ b/hw/moxie/moxiesim.c
@@ -52,13 +52,13 @@ typedef struct {
 
 static void load_kernel(MoxieCPU *cpu, LoaderParams *loader_params)
 {
-    uint64_t entry, kernel_low, kernel_high;
+    uint64_t entry, kernel_high;
     int64_t initrd_size;
     long kernel_size;
     ram_addr_t initrd_offset;
 
     kernel_size = load_elf(loader_params->kernel_filename,  NULL, NULL, NULL,
-                           &entry, &kernel_low, &kernel_high, NULL, 1, EM_MOXIE,
+                           &entry, NULL, &kernel_high, NULL, 1, EM_MOXIE,
                            0, 0);
 
     if (kernel_size <= 0) {