summary refs log tree commit diff stats
path: root/hw/mst_fpga.c
diff options
context:
space:
mode:
authorJeff Cody <jcody@redhat.com>2013-02-26 09:55:48 -0500
committerStefan Hajnoczi <stefanha@redhat.com>2013-03-04 09:54:17 +0100
commit272d2d8e1241b92ab9be87b2c8fb590fd84987a8 (patch)
tree58c9564f3ab0afcd1a357037776ee56df35cee50 /hw/mst_fpga.c
parent1b8bbb46e7593b92ded74cc2a5461202c2b6c05c (diff)
downloadfocaccia-qemu-272d2d8e1241b92ab9be87b2c8fb590fd84987a8.tar.gz
focaccia-qemu-272d2d8e1241b92ab9be87b2c8fb590fd84987a8.zip
block: for HMP commit() operations on 'all', skip non-COW drives
During a commit of 'all' using the HMP non-live commit, the operation
is aborted and returns error on the first error enountered.  When
non-COW drives are in use (e.g. ejected floppy, cdrom, or drives without
a backing parent), that means a commit all will return an error of either
-ENOMEDIUM or -ENOTSUP.  This is not desirable, so for the 'all' commit
case, only attempt the commit if both bs->drv and bs->backing_hd are
present.

More succinctly: 'commit all' now means a commit on all COW drives.

This means an individual commit to a specific non-COW drive will still
return the appropriate error (-ENOMEDIUM if eject / not present, -ENOTSUP
if no backing file).

Reported-by: Jan Kiszka <jan.kiszka@web.de>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'hw/mst_fpga.c')
0 files changed, 0 insertions, 0 deletions