diff options
| author | Niklas Cassel <niklas.cassel@wdc.com> | 2023-10-11 15:12:20 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-11-08 17:56:18 +0100 |
| commit | b523a3d54f3d031a54cd0931cc5d855608e63140 (patch) | |
| tree | c78086b926896075f716f0181c713ed63897f2ed /hw/net/igb_common.h | |
| parent | 1f051dcbdf2e4b6f518db731c84e304b2b9d15ce (diff) | |
| download | focaccia-qemu-b523a3d54f3d031a54cd0931cc5d855608e63140.tar.gz focaccia-qemu-b523a3d54f3d031a54cd0931cc5d855608e63140.zip | |
hw/ide/ahci: trigger either error IRQ or regular IRQ, not both
According to AHCI 1.3.1, 5.3.8.1 RegFIS:Entry, if ERR_STAT is set,
we jump to state ERR:FatalTaskfile, which will raise a TFES IRQ
unconditionally, regardless if the I bit is set in the FIS or not.
Thus, we should never raise a normal IRQ after having sent an error
IRQ.
NOTE: for QEMU platforms that use SeaBIOS, this patch depends on QEMU
commit 784155cdcb02 ("seabios: update submodule to git snapshot"), and
QEMU commit 14f5a7bae4cb ("seabios: update binaries to git snapshot"),
which update SeaBIOS to a version that contains SeaBIOS commit 1281e340
("ahci: handle TFES irq correctly").
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Message-ID: <20231011131220.1992064-1-nks@flawful.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/net/igb_common.h')
0 files changed, 0 insertions, 0 deletions