diff options
| author | Jay Zhou <jianjay.zhou@huawei.com> | 2018-03-02 17:04:44 +0800 |
|---|---|---|
| committer | Jason Wang <jasowang@redhat.com> | 2018-03-05 10:30:16 +0800 |
| commit | 46d4d36d0bf2b24b205f2f604f0905db80264eef (patch) | |
| tree | 0b165bbdc0a9ba3f24fe13243aab59f47a230271 /hw/net/pcnet.c | |
| parent | b20219b6451546b9664ceae471b2622b54f0a4bd (diff) | |
| download | focaccia-qemu-46d4d36d0bf2b24b205f2f604f0905db80264eef.tar.gz focaccia-qemu-46d4d36d0bf2b24b205f2f604f0905db80264eef.zip | |
tap: setting error appropriately when calling net_init_tap_one()
If netdev_add tap,id=net0,...,vhost=on failed in net_init_tap_one(),
the followed up device_add virtio-net-pci,netdev=net0 will fail
too, prints:
TUNSETOFFLOAD ioctl() failed: Bad file descriptor TUNSETOFFLOAD
ioctl() failed: Bad file descriptor
The reason is that the fd of tap is closed when error occured after
calling net_init_tap_one().
The fd should be closed when calling net_init_tap_one failed:
- if tap_set_sndbuf() failed
- if tap_set_sndbuf() succeeded but vhost failed to open or
initialize with vhostforce flag on
- with wrong vhost command line parameter
The fd should not be closed just because vhost failed to open or
initialize but without vhostforce flag. So the followed up
device_add can fall back to userspace virtio successfully.
Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Suggested-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'hw/net/pcnet.c')
0 files changed, 0 insertions, 0 deletions