diff options
| author | Markus Armbruster <armbru@redhat.com> | 2025-09-23 11:09:59 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2025-10-01 08:33:24 +0200 |
| commit | e0c6c38738501ff4f79864ab2b10622433317711 (patch) | |
| tree | 4021c2d0e7d5948bc720c260e82f4454b3414adc /hw/net/virtio-net.c | |
| parent | f3da25a5571573dfd8b5459b3b4458cd4de38db7 (diff) | |
| download | focaccia-qemu-e0c6c38738501ff4f79864ab2b10622433317711.tar.gz focaccia-qemu-e0c6c38738501ff4f79864ab2b10622433317711.zip | |
ivshmem-flat: Mark an instance of missing error handling FIXME
ivshmem-flat's ivshmem_flat_add_vector() neglects to handle qemu_set_blocking() failure. It used to silently ignore errors there. Recent commit 6f607941b1c (treewide: use qemu_set_blocking instead of g_unix_set_fd_nonblocking) changed it to warn (without mentioning it the commit message, tsk, tsk, tsk). Note that ivshmem-pci's process_msg_connect() handles this error. Add a FIXME comment to mark the missing error handling. Cc: Gustavo Romero <gustavo.romero@linaro.org> Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-ID: <20250923091000.3180122-13-armbru@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Diffstat (limited to 'hw/net/virtio-net.c')
0 files changed, 0 insertions, 0 deletions