diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2023-03-30 14:14:31 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2023-04-20 11:17:35 +0200 |
| commit | 3488fc326297831e5d57e6d49ed17d9c1c6d056b (patch) | |
| tree | a1742e1928fdd98f282fc64467f17736f7cf13b7 /hw/nvme/ctrl.c | |
| parent | 0abe33c13adb0ef67bfbbdce30dc5d9735899906 (diff) | |
| download | focaccia-qemu-3488fc326297831e5d57e6d49ed17d9c1c6d056b.tar.gz focaccia-qemu-3488fc326297831e5d57e6d49ed17d9c1c6d056b.zip | |
nvme: remove constant argument to tracepoint
The last argument to -pci_nvme_err_startfail_virt_state is always "OFFLINE" due to the enclosing "if" condition requiring !sctrl->scs. Reported by Coverity. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/nvme/ctrl.c')
| -rw-r--r-- | hw/nvme/ctrl.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index ac24eeb5ed..f59dfe1cbe 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -7158,9 +7158,7 @@ static int nvme_start_ctrl(NvmeCtrl *n) if (pci_is_vf(PCI_DEVICE(n)) && !sctrl->scs) { trace_pci_nvme_err_startfail_virt_state(le16_to_cpu(sctrl->nvi), - le16_to_cpu(sctrl->nvq), - sctrl->scs ? "ONLINE" : - "OFFLINE"); + le16_to_cpu(sctrl->nvq)); return -1; } if (unlikely(n->cq[0])) { |