diff options
| author | Klaus Jensen <k.jensen@samsung.com> | 2024-11-11 12:14:49 +0100 |
|---|---|---|
| committer | Klaus Jensen <k.jensen@samsung.com> | 2024-12-03 07:28:27 +0100 |
| commit | 6651f8f2e5051f6750c2534ab3151339b3c476a2 (patch) | |
| tree | 847878eb39f66315fc5025981383b2db0ac308b4 /hw/nvme/ctrl.c | |
| parent | e85987786d248dd2792944e703ed4d31edbfbc54 (diff) | |
| download | focaccia-qemu-6651f8f2e5051f6750c2534ab3151339b3c476a2.tar.gz focaccia-qemu-6651f8f2e5051f6750c2534ab3151339b3c476a2.zip | |
hw/nvme: take a reference on the subsystem on vf realization
Make sure we grab a reference on the subsystem when a VF is realized.
Otherwise, the subsytem will be unrealized automatically when the VFs
are unregistered and unreffed.
This fixes a latent bug but was not exposed until commit 08f632848008
("pcie: Release references of virtual functions"). This was then fixed
(or rather, hidden) by commit c613ad25125b ("pcie_sriov: Do not manually
unrealize"), but that was then reverted (due to other issues) in commit
b0fdaee5d1ed, exposing the bug yet again.
Cc: qemu-stable@nongnu.org
Fixes: 08f632848008 ("pcie: Release references of virtual functions")
Reviewed-by: Jesper Wendel Devantier <foss@defmacro.it>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Diffstat (limited to 'hw/nvme/ctrl.c')
| -rw-r--r-- | hw/nvme/ctrl.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 61c114c66d..ec75419566 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -8841,6 +8841,13 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp) */ n->params.serial = g_strdup(pn->params.serial); n->subsys = pn->subsys; + + /* + * Assigning this link (strong link) causes an `object_unref` later in + * `object_release_link_property`. Increment the refcount to balance + * this out. + */ + object_ref(OBJECT(pn->subsys)); } if (!nvme_check_params(n, errp)) { |