summary refs log tree commit diff stats
path: root/hw/pci.c
diff options
context:
space:
mode:
authorAnthony Liguori <aliguori@us.ibm.com>2012-03-15 11:29:56 -0500
committerAnthony Liguori <aliguori@us.ibm.com>2012-03-16 13:17:06 -0500
commite5ab1404d014cefe22e9a10fca00d0acf4fe412b (patch)
tree38eb5da7dcb7af1d1b2c43b8b1a1185feb9ea1ca /hw/pci.c
parentae7d54d489540b49b7c13a7df7ddc220588a2ced (diff)
downloadfocaccia-qemu-e5ab1404d014cefe22e9a10fca00d0acf4fe412b.tar.gz
focaccia-qemu-e5ab1404d014cefe22e9a10fca00d0acf4fe412b.zip
pci: fix double free of romfile property
The qdev property release function frees any string properties.  This was
resulting in a double free during hot unplug.

It manifests in network devices because block devices have a NULL romfile
property by default.

Cc: Michael Tsirkin <mst@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/pci.c')
-rw-r--r--hw/pci.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/pci.c b/hw/pci.c
index bf046bfcad..ed8ec99073 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -841,7 +841,6 @@ static int pci_unregister_device(DeviceState *dev)
 
     pci_unregister_io_regions(pci_dev);
     pci_del_option_rom(pci_dev);
-    g_free(pci_dev->romfile);
     do_pci_unregister_device(pci_dev);
     return 0;
 }