diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2013-03-04 11:23:49 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2013-03-26 21:02:17 +0200 |
| commit | 45eb768c706d3a5fbe55224c589e8b4e252781d9 (patch) | |
| tree | d3de1d700976fe8efae8942b64f66d4626137f2b /hw/pci/pci.c | |
| parent | ba7d8515c1e929baccea9f53d06d131fd2b007a1 (diff) | |
| download | focaccia-qemu-45eb768c706d3a5fbe55224c589e8b4e252781d9.tar.gz focaccia-qemu-45eb768c706d3a5fbe55224c589e8b4e252781d9.zip | |
pci_bridge: factor out common code
Reuse common code in pcie_port, override the hardwired-to-0 bits per PCI Express spec. No functional change but makes the code easier to follow. Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/pci/pci.c')
| -rw-r--r-- | hw/pci/pci.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/hw/pci/pci.c b/hw/pci/pci.c index a88160236e..8772707b81 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -668,16 +668,10 @@ static void pci_init_mask_bridge(PCIDevice *d) pci_word_test_and_set_mask(d->config + PCI_PREF_MEMORY_LIMIT, PCI_PREF_RANGE_TYPE_64); -/* TODO: add this define to pci_regs.h in linux and then in qemu. */ -#define PCI_BRIDGE_CTL_VGA_16BIT 0x10 /* VGA 16-bit decode */ -#define PCI_BRIDGE_CTL_DISCARD 0x100 /* Primary discard timer */ -#define PCI_BRIDGE_CTL_SEC_DISCARD 0x200 /* Secondary discard timer */ -#define PCI_BRIDGE_CTL_DISCARD_STATUS 0x400 /* Discard timer status */ -#define PCI_BRIDGE_CTL_DISCARD_SERR 0x800 /* Discard timer SERR# enable */ -/* - * TODO: Bridges default to 10-bit VGA decoding but we currently only - * implement 16-bit decoding (no alias support). - */ + /* + * TODO: Bridges default to 10-bit VGA decoding but we currently only + * implement 16-bit decoding (no alias support). + */ pci_set_word(d->wmask + PCI_BRIDGE_CONTROL, PCI_BRIDGE_CTL_PARITY | PCI_BRIDGE_CTL_SERR | |