summary refs log tree commit diff stats
path: root/hw/pci/pci_host.c
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2014-03-17 16:00:32 +0000
committerMichael Tokarev <mjt@tls.msk.ru>2014-03-27 19:22:49 +0400
commitac43fa508cc1cfe6d6f67c8eb99dc012e52c164e (patch)
tree62817b868442eb4de0dd3605c915624de3afaffe /hw/pci/pci_host.c
parent6d55574a656f3a533a370156aaefedcf7980d4d8 (diff)
downloadfocaccia-qemu-ac43fa508cc1cfe6d6f67c8eb99dc012e52c164e.tar.gz
focaccia-qemu-ac43fa508cc1cfe6d6f67c8eb99dc012e52c164e.zip
hw/pci/pci_host.c: Avoid shifting left into sign bit
Add U suffix to avoid undefined behaviour.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw/pci/pci_host.c')
-rw-r--r--hw/pci/pci_host.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c
index 77c7d1f86b..3e26f9256c 100644
--- a/hw/pci/pci_host.c
+++ b/hw/pci/pci_host.c
@@ -142,8 +142,9 @@ static uint64_t pci_host_data_read(void *opaque,
 {
     PCIHostState *s = opaque;
     uint32_t val;
-    if (!(s->config_reg & (1 << 31)))
+    if (!(s->config_reg & (1U << 31))) {
         return 0xffffffff;
+    }
     val = pci_data_read(s->bus, s->config_reg | (addr & 3), len);
     PCI_DPRINTF("read addr " TARGET_FMT_plx " len %d val %x\n",
                 addr, len, val);