diff options
| author | BALATON Zoltan <balaton@eik.bme.hu> | 2020-07-05 19:22:11 +0200 |
|---|---|---|
| committer | Alistair Francis <alistair.francis@wdc.com> | 2020-09-25 16:52:08 -0700 |
| commit | 617160c9e1f8022563c33aa7fd204535d4d49f8c (patch) | |
| tree | 9bdc09357ec3690c71f21058d88bada7b977bb33 /hw/ppc/mac_oldworld.c | |
| parent | 8d16e72f2d4df2c9e631393adf1669a1da7efe8a (diff) | |
| download | focaccia-qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.tar.gz focaccia-qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.zip | |
load_elf: Remove unused address variables from callers
Several callers of load_elf() pass pointers for lowaddr and highaddr parameters which are then not used for anything. This may stem from a misunderstanding that load_elf need a value here but in fact it can take NULL to ignore these values. Remove such unused variables and pass NULL instead from callers that don't need these. Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> Acked-by: Max Filippov <jcmvbkbc@gmail.com> Message-Id: <20200705174020.BDD0174633F@zero.eik.bme.hu> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'hw/ppc/mac_oldworld.c')
| -rw-r--r-- | hw/ppc/mac_oldworld.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c index 7aba040f1b..f8173934a2 100644 --- a/hw/ppc/mac_oldworld.c +++ b/hw/ppc/mac_oldworld.c @@ -150,7 +150,6 @@ static void ppc_heathrow_init(MachineState *machine) } if (linux_boot) { - uint64_t lowaddr = 0; int bswap_needed; #ifdef BSWAP_NEEDED @@ -160,9 +159,8 @@ static void ppc_heathrow_init(MachineState *machine) #endif kernel_base = KERNEL_LOAD_ADDR; kernel_size = load_elf(kernel_filename, NULL, - translate_kernel_address, NULL, - NULL, &lowaddr, NULL, NULL, 1, PPC_ELF_MACHINE, - 0, 0); + translate_kernel_address, NULL, NULL, NULL, + NULL, NULL, 1, PPC_ELF_MACHINE, 0, 0); if (kernel_size < 0) kernel_size = load_aout(kernel_filename, kernel_base, ram_size - kernel_base, bswap_needed, |