diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2016-10-29 00:01:05 +1100 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2017-01-31 10:10:13 +1100 |
| commit | 5b120785e70a9a48b43e3f1f156a10a015334a28 (patch) | |
| tree | fae58cd4fd3b0d7b3f7c9e2744fbcb9bfa7e3ece /hw/ppc/spapr.c | |
| parent | 0c86d0fd92aaecc2e69041dc747299dbc0be4bb9 (diff) | |
| download | focaccia-qemu-5b120785e70a9a48b43e3f1f156a10a015334a28.tar.gz focaccia-qemu-5b120785e70a9a48b43e3f1f156a10a015334a28.zip | |
pseries: Make cpu_update during CAS unconditional
spapr_h_cas_compose_response() includes a cpu_update parameter which controls whether it includes updated information on the CPUs in the device tree fragment returned from the ibm,client-architecture-support (CAS) call. Providing the updated information is essential when CAS has negotiated compatibility options which require different cpu information to be presented to the guest. However, it should be safe to provide in other cases (it will just override the existing data in the device tree with identical data). This simplifies the code by removing the parameter and always providing the cpu update information. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Diffstat (limited to 'hw/ppc/spapr.c')
| -rw-r--r-- | hw/ppc/spapr.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index cef696caab..ca78e314a5 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -685,7 +685,6 @@ out: int spapr_h_cas_compose_response(sPAPRMachineState *spapr, target_ulong addr, target_ulong size, - bool cpu_update, sPAPROptionVector *ov5_updates) { void *fdt, *fdt_skel; @@ -704,9 +703,7 @@ int spapr_h_cas_compose_response(sPAPRMachineState *spapr, g_free(fdt_skel); /* Fixup cpu nodes */ - if (cpu_update) { - _FDT((spapr_fixup_cpu_dt(fdt, spapr))); - } + _FDT((spapr_fixup_cpu_dt(fdt, spapr))); if (spapr_dt_cas_updates(spapr, fdt, ov5_updates)) { return -1; |