diff options
| author | Amit Shah <amit.shah@redhat.com> | 2011-02-10 12:55:20 +0530 |
|---|---|---|
| committer | Amit Shah <amit.shah@redhat.com> | 2011-03-21 16:57:13 +0530 |
| commit | 2d6c1ef40f3678ab47a4d14fb5dadaa486bfcda6 (patch) | |
| tree | c23a1a315307a23e0e97704a06226ed8288e5729 /hw/qdev-properties.c | |
| parent | f9a90f189c780e066039f2de3906c73c48071bb7 (diff) | |
| download | focaccia-qemu-2d6c1ef40f3678ab47a4d14fb5dadaa486bfcda6.tar.gz focaccia-qemu-2d6c1ef40f3678ab47a4d14fb5dadaa486bfcda6.zip | |
char: Prevent multiple devices opening same chardev
Prevent: -chardev socket,path=/tmp/foo,server,nowait,id=c0 \ -device virtserialport,chardev=c0,id=vs0 \ -device virtserialport,chardev=c0,id=vs1 Reported-by: Mike Cao <bcao@redhat.com> Signed-off-by: Amit Shah <amit.shah@redhat.com>
Diffstat (limited to 'hw/qdev-properties.c')
| -rw-r--r-- | hw/qdev-properties.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index a45b61e7ed..1088a26f8e 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -351,8 +351,13 @@ static int parse_chr(DeviceState *dev, Property *prop, const char *str) CharDriverState **ptr = qdev_get_prop_ptr(dev, prop); *ptr = qemu_chr_find(str); - if (*ptr == NULL) + if (*ptr == NULL) { return -ENOENT; + } + if ((*ptr)->assigned) { + return -EEXIST; + } + (*ptr)->assigned = 1; return 0; } |