summary refs log tree commit diff stats
path: root/hw/qdev-properties.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2010-03-02 14:56:34 +0100
committerMarkus Armbruster <armbru@redhat.com>2010-03-16 17:01:08 +0100
commitcde0fc7544ca590c83f349d4dcccf375d55d6042 (patch)
tree1b31f269b788b772394fd00a077eeae5fc9ea74f /hw/qdev-properties.c
parent6620d3ce9ee44c01c7d715322be7879ad3d98c7a (diff)
downloadfocaccia-qemu-cde0fc7544ca590c83f349d4dcccf375d55d6042.tar.gz
focaccia-qemu-cde0fc7544ca590c83f349d4dcccf375d55d6042.zip
error: Let converted handlers print in human monitor
While fully converted handlers are not supposed to print anything when
running in a QMP monitor, they are free to print in a human monitor.
For instance, device_add (not yet converted) prints help, and will
continue to do so after conversion.

Moreover, utility functions converted to QError should remain usable
from unconverted handlers.

Two problems:

* handler_audit() complains when a converted handler prints.  Limit
  that to QMP monitors.

* With QMP, handlers need to pass the error object by way of
  monitor_set_error().  However, we do that both for QMP and for the
  human monitor.  The human monitor prints the error object after the
  handler returns.  If the handler prints anything else, that output
  "overtakes" the error message.

  Limit use of monitor_set_error() to QMP monitors.  Update
  handler_audit() accordingly.
Diffstat (limited to 'hw/qdev-properties.c')
0 files changed, 0 insertions, 0 deletions