summary refs log tree commit diff stats
path: root/hw/qdev.c
diff options
context:
space:
mode:
authorMark McLoughlin <markmc@redhat.com>2009-09-23 11:24:05 +0100
committerBlue Swirl <blauwirbel@gmail.com>2009-09-25 19:57:51 +0000
commit3df04ac3c63ba6a0ff7417e0f7dd389bc3efb09d (patch)
treefddfd3db38eec559bedd3791344d662f3c7013c6 /hw/qdev.c
parent9262f3841b0ecb866568e3edcc1fee1b05d41e9f (diff)
downloadfocaccia-qemu-3df04ac3c63ba6a0ff7417e0f7dd389bc3efb09d.tar.gz
focaccia-qemu-3df04ac3c63ba6a0ff7417e0f7dd389bc3efb09d.zip
Fix coding style issue
Replace:

  if (-1 == foo())

with:

  if (foo() == -1)

While this coding style is not in direct contravention of our currently
ratified CODING_STYLE treaty, it could be argued that the Article 3 of
the European Convention on Human Rights (prohibiting torture and "inhuman
or degrading treatment") reads on the matter.

[This commit message was brought to you without humour, as is evidenced
by the absence of any emoticons]

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Cc: Avi Kivity <avi@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Diffstat (limited to 'hw/qdev.c')
-rw-r--r--hw/qdev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/qdev.c b/hw/qdev.c
index 43b1beb258..a589d72406 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -137,7 +137,7 @@ static int set_property(const char *name, const char *value, void *opaque)
     if (strcmp(name, "bus") == 0)
         return 0;
 
-    if (-1 == qdev_prop_parse(dev, name, value)) {
+    if (qdev_prop_parse(dev, name, value) == -1) {
         qemu_error("can't set property \"%s\" to \"%s\" for \"%s\"\n",
                    name, value, dev->info->name);
         return -1;