diff options
| author | Markus Armbruster <armbru@redhat.com> | 2010-06-01 20:32:31 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2010-06-04 11:43:39 +0200 |
| commit | d21357df9a2a6b7e6bb2f579d04877f3bd65c557 (patch) | |
| tree | 7397e5342d9c2e51eddfe63b38a13b63d966fb2d /hw/qdev.h | |
| parent | cc98467327e13adca8f65b5a841c08930ee68220 (diff) | |
| download | focaccia-qemu-d21357df9a2a6b7e6bb2f579d04877f3bd65c557.tar.gz focaccia-qemu-d21357df9a2a6b7e6bb2f579d04877f3bd65c557.zip | |
qdev: Don't leak string property value on hot unplug
parse_string() qemu_strdup()s the property value. It is never freed. It needs to be freed along with the device. Otherwise, the value of scsi-disk property "ver" gets leaked when hot-unplugging the disk, for instance. Call new PropertyInfo method free() from qdev_free(). Implement it for qdev_prop_string. Signed-off-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/qdev.h')
| -rw-r--r-- | hw/qdev.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/qdev.h b/hw/qdev.h index 7c25a9414e..51a24e271c 100644 --- a/hw/qdev.h +++ b/hw/qdev.h @@ -98,6 +98,7 @@ struct PropertyInfo { enum PropertyType type; int (*parse)(DeviceState *dev, Property *prop, const char *str); int (*print)(DeviceState *dev, Property *prop, char *dest, size_t len); + void (*free)(DeviceState *dev, Property *prop); }; typedef struct GlobalProperty { |