diff options
| author | Alon Levy <alevy@redhat.com> | 2012-03-18 13:46:13 +0100 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2012-03-19 13:12:19 +0100 |
| commit | aa3db4236e3bf1786c8cefab2a95e29a9781caff (patch) | |
| tree | 75a0a5d505cb584c5dbfb7ee5571e6f720594e25 /hw/qxl.c | |
| parent | 6ec5dae5a49f2933dc9b3925d8054eb380a56d88 (diff) | |
| download | focaccia-qemu-aa3db4236e3bf1786c8cefab2a95e29a9781caff.tar.gz focaccia-qemu-aa3db4236e3bf1786c8cefab2a95e29a9781caff.zip | |
qxl: init_pipe_signaling: exit on failure
If pipe creation fails, exit, don't log and continue. Fix indentation at the same time. Signed-off-by: Alon Levy <alevy@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/qxl.c')
| -rw-r--r-- | hw/qxl.c | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/hw/qxl.c b/hw/qxl.c index e17b0e31af..26ca893e31 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1452,16 +1452,17 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t events) static void init_pipe_signaling(PCIQXLDevice *d) { - if (pipe(d->pipe) < 0) { - dprint(d, 1, "%s: pipe creation failed\n", __FUNCTION__); - return; - } - fcntl(d->pipe[0], F_SETFL, O_NONBLOCK); - fcntl(d->pipe[1], F_SETFL, O_NONBLOCK); - fcntl(d->pipe[0], F_SETOWN, getpid()); - - qemu_thread_get_self(&d->main); - qemu_set_fd_handler(d->pipe[0], pipe_read, NULL, d); + if (pipe(d->pipe) < 0) { + fprintf(stderr, "%s:%s: qxl pipe creation failed\n", + __FILE__, __func__); + exit(1); + } + fcntl(d->pipe[0], F_SETFL, O_NONBLOCK); + fcntl(d->pipe[1], F_SETFL, O_NONBLOCK); + fcntl(d->pipe[0], F_SETOWN, getpid()); + + qemu_thread_get_self(&d->main); + qemu_set_fd_handler(d->pipe[0], pipe_read, NULL, d); } /* graphics console */ |