diff options
| author | Max Reitz <mreitz@redhat.com> | 2021-06-24 10:38:24 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2021-07-20 16:49:31 +0200 |
| commit | 8573823f3ba2b63926f82d5732473e0cd73c1213 (patch) | |
| tree | 168930d75dbb0d0044e47a2be1eb915e20b1fb00 /hw/remote/memory.c | |
| parent | 6af72274efd580fbfc048aad75d3e9af44614590 (diff) | |
| download | focaccia-qemu-8573823f3ba2b63926f82d5732473e0cd73c1213.tar.gz focaccia-qemu-8573823f3ba2b63926f82d5732473e0cd73c1213.zip | |
block/export: Conditionally ignore set-context error
When invoking block-export-add with some iothread and
fixed-iothread=false, and changing the node's iothread fails, the error
is supposed to be ignored.
However, it is still stored in *errp, which is wrong. If a second error
occurs, the "*errp must be NULL" assertion in error_setv() fails:
qemu-system-x86_64: ../util/error.c:59: error_setv: Assertion
`*errp == NULL' failed.
So if fixed-iothread=false, we should ignore the error by passing NULL
to bdrv_try_set_aio_context().
Fixes: f51d23c80af73c95e0ce703ad06a300f1b3d63ef
("block/export: add iothread and fixed-iothread options")
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210624083825.29224-2-mreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/remote/memory.c')
0 files changed, 0 insertions, 0 deletions