summary refs log tree commit diff stats
path: root/hw/remote/proxy.c
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2023-05-23 17:56:33 +0200
committerPaolo Bonzini <pbonzini@redhat.com>2023-06-26 10:23:01 +0200
commit6c5f893d1771edc49fe6d3f8580be19a42b3b118 (patch)
treefd9057c6ba8fe0b54d8165761b125c9eb6863416 /hw/remote/proxy.c
parent79dbd910c9ea6ca38f8e1b2616b1e5e885b85bd3 (diff)
downloadfocaccia-qemu-6c5f893d1771edc49fe6d3f8580be19a42b3b118.tar.gz
focaccia-qemu-6c5f893d1771edc49fe6d3f8580be19a42b3b118.zip
build: further refine build.ninja rules
In commit b0fcc6fc7fc1 ("build: rebuild build.ninja using
"meson setup --reconfigure"", 2023-05-19) I changed the build.ninja
rule in the Makefile to use "meson setup" so that the Makefile would
pick up a changed path to the meson binary.

However, there was a reason why build.ninja was rebuilt using $(NINJA)
itself.  Namely, ninja has its own cache of file modification times,
and if it does not know about the modification that was done outside
its control, it will *also* try to regenerate build.ninja.  This can be
simply by running "make" on a fresh tree immediately after "configure";
that will trigger an unnecessary meson run.

So, apply a refinement to the rule in order to cover both cases:

- track the meson binary that was used (and that is embedded in
  build.ninja's reconfigure rules); to do this, write build.ninja.stamp
  right after executing meson successfully

- if it changed, force usage of "$(MESON) setup --reconfigure" to
  update the path in the reconfigure rule

- if it didn't change, use "$(NINJA) build.ninja" just like before
  commit b0fcc6fc7fc1.

Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/remote/proxy.c')
0 files changed, 0 insertions, 0 deletions