summary refs log tree commit diff stats
path: root/hw/s390x/css-bridge.c
diff options
context:
space:
mode:
authorPeter Lieven <pl@kamp.de>2016-07-18 10:52:19 +0200
committerPaolo Bonzini <pbonzini@redhat.com>2016-07-19 08:34:53 +0200
commiteb36b953e0ebf4129b188a241fbc367062ac2e06 (patch)
tree9a01fb374bfcccd725e6478f1000f2ee149d386c /hw/s390x/css-bridge.c
parente5dfc5e8e715c572aea44ac4d96c43941d4741c7 (diff)
downloadfocaccia-qemu-eb36b953e0ebf4129b188a241fbc367062ac2e06.tar.gz
focaccia-qemu-eb36b953e0ebf4129b188a241fbc367062ac2e06.zip
block/iscsi: fix rounding in iscsi_allocationmap_set
when setting clusters as alloacted the boundaries have
to be expanded. As Paolo pointed out the calculation of
the number of clusters is wrong:

Suppose cluster_sectors is 2, sector_num = 1, nb_sectors = 6:

In the "mark allocated" case, you want to set 0..8, i.e.
cluster_num=0, nb_clusters=4.

   0--.--2--.--4--.--6--.--8
   <--|_________________|-->  (<--> = expanded)

Instead you are setting nb_clusters=3, so that 6..8 is not marked.

   0--.--2--.--4--.--6--.--8
   <--|______________|!!!     (! = wrong)

Cc: qemu-stable@nongnu.org
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Lieven <pl@kamp.de>
Message-Id: <1468831940-15556-2-git-send-email-pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/s390x/css-bridge.c')
0 files changed, 0 insertions, 0 deletions