summary refs log tree commit diff stats
path: root/hw/scsi/esp-pci.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2018-02-15 11:15:26 +0000
committerPaolo Bonzini <pbonzini@redhat.com>2019-01-11 13:57:24 +0100
commit88e94fd238aa425c1a19d64afd1b3c83dfeb7dc2 (patch)
tree98d996062a20d8740e898766aa30dff1704e6514 /hw/scsi/esp-pci.c
parentc100448790b8494ca69f89a88c5833d767a87dc1 (diff)
downloadfocaccia-qemu-88e94fd238aa425c1a19d64afd1b3c83dfeb7dc2.tar.gz
focaccia-qemu-88e94fd238aa425c1a19d64afd1b3c83dfeb7dc2.zip
block/iscsi: cancel libiscsi task when ABORT TASK TMF completes
The libiscsi iscsi_task_mgmt_async() API documentation says:

  abort_task will also cancel the scsi task. The callback for the scsi
  task will be invoked with SCSI_STATUS_CANCELLED

The libiscsi implementation does not fulfil this promise.  The task's
callback is not invoked and its struct iscsi_pdu remains in the internal
list (effectively leaked).

This patch invokes the libiscsi iscsi_scsi_cancel_task() API to force
the task's callback to be invoked with SCSI_STATUS_CANCELLED when the
ABORT TASK TMF completes and the task's callback hasn't been invoked
yet.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20180215111526.2464-1-stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/scsi/esp-pci.c')
0 files changed, 0 insertions, 0 deletions