diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2016-10-20 13:57:06 +0100 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2016-10-28 18:17:23 +0300 |
| commit | 35b6e94ba50cd92600a85eef444bc31df8999de1 (patch) | |
| tree | 271f3dcb3320d30eadafba117a5468e75a407bbb /hw/timer/grlib_gptimer.c | |
| parent | 25174055f428254427e7541139037eb9a34fc109 (diff) | |
| download | focaccia-qemu-35b6e94ba50cd92600a85eef444bc31df8999de1.tar.gz focaccia-qemu-35b6e94ba50cd92600a85eef444bc31df8999de1.zip | |
s390: avoid always-true comparison in s390_pci_generate_fid()
Coverity points out that the comparison "fid <= ZPCI_MAX_FID" in s390_pci_generate_fid() is always true (because fid is 32 bits and ZPCI_MAX_FID is 0xffffffff). This isn't a bug because the real loop termination condition is expressed later via an "if (...) break;" inside the loop, but it is a bit odd. Rephrase the loop to avoid the unnecessary duplicate-but-never-true conditional. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw/timer/grlib_gptimer.c')
0 files changed, 0 insertions, 0 deletions