summary refs log tree commit diff stats
path: root/hw/timer/omap_gptimer.c
diff options
context:
space:
mode:
authorDaniel P. Berrange <berrange@redhat.com>2017-02-03 12:06:42 +0000
committerGerd Hoffmann <kraxel@redhat.com>2017-02-08 14:59:37 +0100
commit1b1aeb5828c978af2ec4478e552884004f23c470 (patch)
tree56593705cea430a5eb198ef0fc9c8d9a34b4ab9f /hw/timer/omap_gptimer.c
parent537848ee62195fc06c328b1cd64f4218f404a7f1 (diff)
downloadfocaccia-qemu-1b1aeb5828c978af2ec4478e552884004f23c470.tar.gz
focaccia-qemu-1b1aeb5828c978af2ec4478e552884004f23c470.zip
ui: fix regression handling bare 'websocket' option to -vnc
The -vnc argument is documented as accepting two syntaxes for
the 'websocket' option, either a bare option name, or a port
number. If using the bare option name, it is supposed to apply
the display number as an offset to base port 5700. e.g.

  -vnc localhost:3,websocket

should listen on port 5703, however, this was broken in 2.3.0 since

  commit 4db14629c38611061fc19ec6927405923de84f08
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   Tue Sep 16 12:33:03 2014 +0200

    vnc: switch to QemuOpts, allow multiple servers

instead qemu tries to listen on port "on" which gets looked up in
/etc/services and fails.

Fixes bug: #1455912

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-id: 20170203120649.15637-2-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/timer/omap_gptimer.c')
0 files changed, 0 insertions, 0 deletions