diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2020-06-12 10:54:40 +0200 |
|---|---|---|
| committer | Stefan Berger <stefanb@linux.vnet.ibm.com> | 2020-06-19 07:25:31 -0400 |
| commit | f670a562af4bd6ef9adee7654cf5129f14a277a8 (patch) | |
| tree | bd3fd3cbfbca18d510a6fadaf85dda78b07b6fa1 /hw/tpm/tpm_util.c | |
| parent | 680725651799e4f1c74a29b6fc5813708c786747 (diff) | |
| download | focaccia-qemu-f670a562af4bd6ef9adee7654cf5129f14a277a8.tar.gz focaccia-qemu-f670a562af4bd6ef9adee7654cf5129f14a277a8.zip | |
hw/tpm: Make TRACE_TPM_UTIL_SHOW_BUFFER check local to tpm_util.c
The trace_event_get_state_backends() call is useful to avoid making extensive calls (usually preparing arguments passed to the tracing framework. In this case, the extensive work is done in tpm_util_show_buffer(), and the arguments used to call it don't involve extra processing. Simplify by moving the TRACE_TPM_UTIL_SHOW_BUFFER check to tpm_util_show_buffer. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com> Message-id: 20200612085444.8362-9-philmd@redhat.com Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Diffstat (limited to 'hw/tpm/tpm_util.c')
| -rw-r--r-- | hw/tpm/tpm_util.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/hw/tpm/tpm_util.c b/hw/tpm/tpm_util.c index c0a0f3d71f..12f19465c5 100644 --- a/hw/tpm/tpm_util.c +++ b/hw/tpm/tpm_util.c @@ -357,6 +357,9 @@ void tpm_util_show_buffer(const unsigned char *buffer, size_t len, i; char *line_buffer, *p; + if (!trace_event_get_state_backends(TRACE_TPM_UTIL_SHOW_BUFFER)) { + return; + } len = MIN(tpm_cmd_get_size(buffer), buffer_size); /* |