diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2010-02-08 23:36:02 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2010-02-14 16:10:54 +0200 |
| commit | a408b1de524d47f475a0225d64d0958d70ae779d (patch) | |
| tree | f16c7d9530e84ce535783d78349ce3de7858c0c0 /hw/versatile_pci.c | |
| parent | 01764fe045d19b2624afc8721d7f5ec798a085ce (diff) | |
| download | focaccia-qemu-a408b1de524d47f475a0225d64d0958d70ae779d.tar.gz focaccia-qemu-a408b1de524d47f475a0225d64d0958d70ae779d.zip | |
versatile_pci: cleanup
Cleanup versatile_pci: no need to re-set fields to zero (pci core sets 0 already), use set_word for status field. Compile-tested only, but seems obvious. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/versatile_pci.c')
| -rw-r--r-- | hw/versatile_pci.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c index e58b7f424d..7048fb84d0 100644 --- a/hw/versatile_pci.c +++ b/hw/versatile_pci.c @@ -147,15 +147,8 @@ static int versatile_pci_host_init(PCIDevice *d) pci_config_set_vendor_id(d->config, PCI_VENDOR_ID_XILINX); /* Both boards have the same device ID. Oh well. */ pci_config_set_device_id(d->config, PCI_DEVICE_ID_XILINX_XC2VP30); - /* TODO: no need to clear command */ - pci_set_byte(d->config + PCI_COMMAND, 0x00); - pci_set_byte(d->config + PCI_COMMAND + 1, 0x00); - /* TODO: convert to set_word */ - pci_set_byte(d->config + PCI_STATUS, PCI_STATUS_66MHZ); - pci_set_byte(d->config + PCI_STATUS + 1, PCI_STATUS_DEVSEL_MEDIUM >> 8); - /* TODO: no need to clear revision/prog ifc */ - pci_set_byte(d->config + PCI_REVISION_ID, 0x00); - pci_set_byte(d->config + PCI_CLASS_PROG, 0x00); + pci_set_word(d->config + PCI_STATUS, + PCI_STATUS_66MHZ | PCI_STATUS_DEVSEL_MEDIUM); pci_config_set_class(d->config, PCI_CLASS_PROCESSOR_CO); pci_set_byte(d->config + PCI_LATENCY_TIMER, 0x10); return 0; |