diff options
| author | Xiang Chen <chenxiang66@hisilicon.com> | 2022-04-16 17:08:24 +0800 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2022-05-06 09:06:50 -0600 |
| commit | 99510d271b173f21a7a1e8a238b5f35d9e88a147 (patch) | |
| tree | 3b57e8a1bfa6079e21ba473572390dd6f075c2d6 /hw/vfio/common.c | |
| parent | dc580d51f7dd3e02134957be2b771636ac59e868 (diff) | |
| download | focaccia-qemu-99510d271b173f21a7a1e8a238b5f35d9e88a147.tar.gz focaccia-qemu-99510d271b173f21a7a1e8a238b5f35d9e88a147.zip | |
vfio/common: Fix a small boundary issue of a trace
It uses [offset, offset + size - 1] to indicate that the length of range is size in most places in vfio trace code (such as trace_vfio_region_region_mmap()) execpt trace_vfio_region_sparse_mmap_entry(). So change it for trace_vfio_region_sparse_mmap_entry(), but if size is zero, the trace will be weird with an underflow, so move the trace and trace it only if size is not zero. Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com> Link: https://lore.kernel.org/r/1650100104-130737-1-git-send-email-chenxiang66@hisilicon.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'hw/vfio/common.c')
| -rw-r--r-- | hw/vfio/common.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 2b1f78fdfa..6065834717 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -1544,11 +1544,10 @@ static int vfio_setup_region_sparse_mmaps(VFIORegion *region, region->mmaps = g_new0(VFIOMmap, sparse->nr_areas); for (i = 0, j = 0; i < sparse->nr_areas; i++) { - trace_vfio_region_sparse_mmap_entry(i, sparse->areas[i].offset, - sparse->areas[i].offset + - sparse->areas[i].size); - if (sparse->areas[i].size) { + trace_vfio_region_sparse_mmap_entry(i, sparse->areas[i].offset, + sparse->areas[i].offset + + sparse->areas[i].size - 1); region->mmaps[j].offset = sparse->areas[i].offset; region->mmaps[j].size = sparse->areas[i].size; j++; |