diff options
| author | Tomita Moeko <tomitamoeko@gmail.com> | 2025-07-24 00:09:06 +0800 |
|---|---|---|
| committer | Cédric Le Goater <clg@redhat.com> | 2025-07-28 17:52:34 +0200 |
| commit | 0db7e4cb62026196f06755c77f943294d9879e5a (patch) | |
| tree | 0c5d3f864c44d77730e7fb2f71d8f1517f46d1ab /hw/vfio/igd.c | |
| parent | e0b33efe2acc3c6c651bb761394ef597e763e349 (diff) | |
| download | focaccia-qemu-0db7e4cb62026196f06755c77f943294d9879e5a.tar.gz focaccia-qemu-0db7e4cb62026196f06755c77f943294d9879e5a.zip | |
vfio/igd: Fix VGA regions are not exposed in legacy mode
In commit a59d06305fff ("vfio/pci: Introduce x-pci-class-code option"),
pci_register_vga() has been moved ouside of vfio_populate_vga(). As a
result, IGD VGA ranges are no longer properly exposed to guest.
To fix this, call pci_register_vga() after vfio_populate_vga() legacy
mode. A wrapper function vfio_pci_config_register_vga() is introduced
to handle it.
Fixes: a59d06305fff ("vfio/pci: Introduce x-pci-class-code option")
Signed-off-by: Tomita Moeko <tomitamoeko@gmail.com>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20250723160906.44941-3-tomitamoeko@gmail.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Diffstat (limited to 'hw/vfio/igd.c')
| -rw-r--r-- | hw/vfio/igd.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c index 5b1ad1a804..ee0767b0b8 100644 --- a/hw/vfio/igd.c +++ b/hw/vfio/igd.c @@ -574,9 +574,13 @@ static bool vfio_pci_igd_config_quirk(VFIOPCIDevice *vdev, Error **errp) * If VGA is not already enabled, try to enable it. We shouldn't be * using legacy mode without VGA. */ - if (!vdev->vga && !vfio_populate_vga(vdev, &err)) { - error_setg(&err, "Unable to enable VGA access"); - goto error; + if (!vdev->vga) { + if (vfio_populate_vga(vdev, &err)) { + vfio_pci_config_register_vga(vdev); + } else { + error_setg(&err, "Unable to enable VGA access"); + goto error; + } } /* Enable OpRegion and LPC bridge quirk */ |