diff options
| author | Roman Kagan <rvkagan@yandex-team.ru> | 2021-11-11 18:33:49 +0300 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2022-01-07 05:19:55 -0500 |
| commit | 6dcae534e82520aa2280009de4b78a19059e8bbb (patch) | |
| tree | 8e6368088cfc00562940ceed16dd1794edccd7f2 /hw/virtio/vhost-backend.c | |
| parent | 666265036fec3fd3eed2d55ae828c915a084a1d6 (diff) | |
| download | focaccia-qemu-6dcae534e82520aa2280009de4b78a19059e8bbb.tar.gz focaccia-qemu-6dcae534e82520aa2280009de4b78a19059e8bbb.zip | |
vhost-backend: avoid overflow on memslots_limit
Fix the (hypothetical) potential problem when the value parsed out of the vhost module parameter in sysfs overflows the return value from vhost_kernel_memslots_limit. Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru> Message-Id: <20211111153354.18807-6-rvkagan@yandex-team.ru> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/virtio/vhost-backend.c')
| -rw-r--r-- | hw/virtio/vhost-backend.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c index b65f8f7e97..44f7dbb243 100644 --- a/hw/virtio/vhost-backend.c +++ b/hw/virtio/vhost-backend.c @@ -58,7 +58,7 @@ static int vhost_kernel_memslots_limit(struct vhost_dev *dev) if (g_file_get_contents("/sys/module/vhost/parameters/max_mem_regions", &s, NULL, NULL)) { uint64_t val = g_ascii_strtoull(s, NULL, 10); - if (!((val == G_MAXUINT64 || !val) && errno)) { + if (val < INT_MAX && val > 0) { g_free(s); return val; } |